executor: add include guards to KVM headers #6430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we also want to remove these ifdefs from the resulting C reproducer code? Or are they already? |
Member
Author
|
At least there are no #ifdef directives in the prog2c output |
Collaborator
|
What about the defines like |
Not having these results in three copies of every KVM-related #define in each reproducer.
ramosian-glider
force-pushed
the
ifdefs
branch
from
ff94360 to
ebfcce5
Compare
Member
Author
|
@a-nogikh fixed csource.go to remove those. |
ramosian-glider
force-pushed
the
ifdefs
branch
from
ebfcce5 to
440a928
Compare
dvyukov
reviewed
Oct 23, 2025
dvyukov
reviewed
Oct 23, 2025
dvyukov
reviewed
Oct 23, 2025
dvyukov
reviewed
Oct 23, 2025
ramosian-glider
force-pushed
the
ifdefs
branch
2 times, most recently
from
cd10d70 to
71818c9
Compare
Drop all lines matching `#define [A-Z0-9_]*_H` from the reproducers
ramosian-glider
force-pushed
the
ifdefs
branch
from
71818c9 to
6fbe3e0
Compare
Member
Author
|
PTAL |
a-nogikh
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having these results in three copies of every KVM-related #define in each reproducer.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md