few assorted changes in preparation syz-agent binary #6476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dvyukov
commented
Nov 24, 2025
dvyukov
commented
- pkg/hash: support hashing strings
- pkg/updater: factor out of syz-ci
- pkg/osutil: move Semaphore from pkg/instance
- pkg/mgrconfig: export SplitTarget function
Currently passing wrong types (e.g. a string) to hash.Hash/String leads to silent misbehavior: the part is ignored in the hash. This is a very bad failure mode. Panic loudly. And support hashing strings.
dvyukov
changed the title
dvyukov
changed the title
Factor syzkaller updating functionality out of syz-ci so that it can be reused in other binaries. No functional changes intended.
Semaphore is a very low-level primitive type, while pkg/instance is a very high-level package with lots of deps. Semaphore does not belong there, and may lead to cyclic deps if we use it more. Move it to pkg/osutil. It's not really OS-specific, but we don't have a better package.
It will be useful for new syz-agent binary in the future.
dvyukov
force-pushed
the
dvyukov-agent-preparation
branch
from
a88e365 to
b4bee18
Compare
a-nogikh
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.