dashboard/app: fix comment reference to ExternalConfig struct #6500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-nogikh
reviewed
Dec 10, 2025
Commit b190f06 ("dashboard/app: fix testing for go1.11 runtime") removed the unused ExternalConfig struct. However, config.go still refers to ExternalConfig in a comment explaining how it can be used to attach to external reporting systems. Change this to say the user can implement their own type if they need. Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
ajdlinux
force-pushed
the
remove-external-config-comment
branch
from
605c856 to
472e2a7
Compare
Contributor
Author
|
@a-nogikh is this better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b190f06 ("dashboard/app: fix testing for go1.11 runtime") removed the unused ExternalConfig struct. Remove the now-incorrect remaining reference to it in a comment.