dashboard/app: fix admin checks for dev_appserver #6519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvyukov
force-pushed
the
dvyukov-devappserver-admin-check
branch
from
d04c6af to
9634920
Compare
tarasmadan
previously approved these changes
Dec 22, 2025
The test uses test names with spaces, testing package replaces spaces with _. As the result, it's impossible to search for failed tests, and they all look very similar. Replace space with _, so that it's possible to search for failed tests.
dvyukov
force-pushed
the
dvyukov-devappserver-admin-check
branch
2 times, most recently
from
ea0ac47 to
bf25cfd
Compare
Admin checks broke at some point for local app runs (the auth domain is overriden only in tests). Restore proper checking for dev_appserver.
dvyukov
force-pushed
the
dvyukov-devappserver-admin-check
branch
from
bf25cfd to
a67443e
Compare
a-nogikh
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin checks broke at some point for local app runs
(the auth domain is overriden only in tests).
Restore proper checking for dev_appserver.