-
Notifications
You must be signed in to change notification settings - Fork 1.4k
dashboard/app: make it possible to test code that uses spanner #6529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dvyukov
commented
Dec 29, 2025
- tools/docker/env: add spanner emulator
- dashboard/app: make it possible to test code that uses spanner
3ae982b to
c46d667
Compare
|
FWIW there's already syz-cluster code that interacts with the spanner emulator: I wonder if we can somehow reuse that instead of duplicating the functionality. |
|
And let me remind about the mocking code in case you'll find it useful: https://github.com/google/syzkaller/tree/master/pkg/coveragedb/mocks |
c46d667 to
1fef5ad
Compare
No, I don't want to use mocks. With mocks:
Using the emulator solves all of the above. |
Ok, let's start with #6533 then ;) |
f8213bf to
fa93e10
Compare
Done. Reused emulator start code and create instance/database from the existing code. |
fa93e10 to
203b9f1
Compare
203b9f1 to
ca90bd4
Compare
ca90bd4 to
87f98ed
Compare
Start spanner emulator for tests. Create isolated per-test instance+database. Test that DDL migration scripts are work.
87f98ed to
a2515d5
Compare