Skip to content

Conversation

@dvyukov
Copy link
Collaborator

@dvyukov dvyukov commented Dec 29, 2025

Don't show package update errors, they happen in hundreds every day.
Don't show internal datastore bugs (these are not our bugs).

@a-nogikh
Copy link
Collaborator

Why not add extra filtering to the query itself?

@dvyukov
Copy link
Collaborator Author

dvyukov commented Dec 29, 2025

Why not add extra filtering to the query itself?

How can I do that?

@a-nogikh
Copy link
Collaborator

We already have some filtering:

iter := adminClient.Entries(c,
logadmin.Filter(
// We filter our instances.delete errors as false positives. Delete event happens every second.
// Also, ignore GKE logs since it streams all stderr output as severity=ERROR.
fmt.Sprintf(`(NOT protoPayload.methodName:v1.compute.instances.delete)`+
` AND (NOT resource.type="k8s_container") AND timestamp > "%s" AND severity>="ERROR"`,
lastWeek)),
logadmin.NewestFirst(),
)

@dvyukov
Copy link
Collaborator Author

dvyukov commented Dec 29, 2025

We already have some filtering:

iter := adminClient.Entries(c,
logadmin.Filter(
// We filter our instances.delete errors as false positives. Delete event happens every second.
// Also, ignore GKE logs since it streams all stderr output as severity=ERROR.
fmt.Sprintf(`(NOT protoPayload.methodName:v1.compute.instances.delete)`+
` AND (NOT resource.type="k8s_container") AND timestamp > "%s" AND severity>="ERROR"`,
lastWeek)),
logadmin.NewestFirst(),
)

How can I filter for that?
I am trying the following query, but it does not return anything at all.

(NOT protoPayload.methodName:v1.compute.instances.delete) AND (NOT resource.type="k8s_container") AND timestamp > "2025-12-20" AND severity>="ERROR" AND (NOT textPayload CONTAINS "datastore_v3: INTERNAL_ERROR") AND (NOT jsonPayload.MESSAGE CONTAINS "packages.GetPackageUpdates()")

@dvyukov dvyukov force-pushed the dvyukov-dashboard-error-log branch from 9c4d32c to f76ea43 Compare December 29, 2025 14:31
@a-nogikh
Copy link
Collaborator

This works:

(NOT protoPayload.methodName:v1.compute.instances.delete) AND (NOT resource.type="k8s_container") AND timestamp > "2025-12-20" AND severity>="ERROR" AND (NOT textPayload:"datastore_v3: INTERNAL_ERROR") AND (NOT jsonPayload.message:"packages.GetPackageUpdates()")

(After looking at the results)
I think we also want to filter out Cloud Build messages.

Don't show package update errors, they happen in hundreds every day.
Don't show internal datastore bugs (these are not our bugs).
@dvyukov dvyukov force-pushed the dvyukov-dashboard-error-log branch from f76ea43 to 7fee06a Compare December 30, 2025 10:08
@dvyukov
Copy link
Collaborator Author

dvyukov commented Dec 30, 2025

This works:

(NOT protoPayload.methodName:v1.compute.instances.delete) AND (NOT resource.type="k8s_container") AND timestamp > "2025-12-20" AND severity>="ERROR" AND (NOT textPayload:"datastore_v3: INTERNAL_ERROR") AND (NOT jsonPayload.message:"packages.GetPackageUpdates()")

Thanks!
Updated the change.
PTAL

(After looking at the results) I think we also want to filter out Cloud Build messages.

Agree. They don't even look like errors. At least it's impossible to understand what's wrong.

@dvyukov dvyukov requested a review from tarasmadan December 30, 2025 10:09
@dvyukov dvyukov added this pull request to the merge queue Dec 30, 2025
Merged via the queue into google:master with commit d32f762 Dec 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants