Skip to content

pkg/report: fix fuchsia Parse #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarasmadan merged 1 commit into from
Jan 9, 2026
Merged

pkg/report: fix fuchsia Parse #6566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pkg/report/fuchsia.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,14 @@ func (ctx *fuchsia) ContainsCrash(output []byte) bool {

func (ctx *fuchsia) Parse(output []byte) *Report {
// We symbolize here because zircon output does not contain even function names.
symbolized := ctx.symbolize(output)
symbolized, l2l := ctx.symbolize(output)
rep := simpleLineParser(symbolized, fuchsiaOopses, fuchsiaStackParams, ctx.ignores)
if rep == nil {
return nil
}
rep.Output = output
rep.StartPos = l2l[rep.StartPos]
rep.EndPos = l2l[rep.EndPos+1] - 1 // EndPos points to '\n'. Mapping has information about the next symbols.
if report := ctx.shortenReport(rep.Report); len(report) != 0 {
rep.Report = report
}
Expand Down Expand Up @@ -132,14 +134,19 @@ func (ctx *fuchsia) shortenReport(report []byte) []byte {
return out.Bytes()
}

func (ctx *fuchsia) symbolize(output []byte) []byte {
// symbolize additionally returns the mapping new_line_pos -> old_line_pos.
func (ctx *fuchsia) symbolize(output []byte) ([]byte, map[int]int) {
l2l := map[int]int{}
var inPos int
symb := symbolizer.Make(ctx.config.target)
defer symb.Close()
out := new(bytes.Buffer)

lines := lines(output)
for i := 0; i < len(lines); i++ {
line := lines[i]
l2l[out.Len()] = inPos
inPos += len(line) + 1
if bytes.Contains(line, zirconAssertFailed) && len(line) == 127 {
// This is super hacky: but zircon splits the most important information in long assert lines
// (and they are always long) into several lines in irreversible way. Try to restore full line.
Expand All @@ -163,7 +170,7 @@ func (ctx *fuchsia) symbolize(output []byte) []byte {
out.Write(line)
out.WriteByte('\n')
}
return out.Bytes()
return out.Bytes(), l2l
}

func (ctx *fuchsia) processPC(out *bytes.Buffer, symb symbolizer.Symbolizer,
Expand Down
Loading