Skip to content

pkg, prog: enable ifuzz for riscv64 #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-nogikh merged 1 commit into from
Jan 22, 2026
Merged

pkg, prog: enable ifuzz for riscv64 #6632

a-nogikh merged 1 commit into from
Jan 22, 2026

Conversation

@6eanut
Copy link
Contributor

@6eanut 6eanut commented Jan 19, 2026 •
edited
Loading

go test in pkg/ifuzz：
image

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

@6eanut 6eanut force-pushed the upstream/ifuzz branch 8 times, most recently from 8371fac to 04f6af4 Compare January 19, 2026 16:08
@6eanut 6eanut mentioned this pull request Jan 20, 2026
Merged
@6eanut
Copy link
Contributor Author

6eanut commented Jan 20, 2026

@a-nogikh
Hi! This PR should be ready for review now — all checks are passing.
Any feedback would be very welcome. Thanks!

@a-nogikh a-nogikh self-requested a review January 20, 2026 09:03
@6eanut
Copy link
Contributor Author

6eanut commented Jan 20, 2026 •
edited
Loading

@a-nogikh
Hi~ The conflict has been resolved.

@6eanut
Copy link
Contributor Author

6eanut commented Jan 21, 2026

Here are some new test cases to illustrate ifuzz adaptation in riscv64:
I ran syzkaller for a while. Then I found a seed containing syz_kvm_setup_cpu$riscv64 and put the corresponding code into testData in the TestDecodeSamples_rv function of pkg/ifuzz/riscv64_test.go. Then run go test and see that it parses correctly.
image
image

a-nogikh
a-nogikh reviewed Jan 21, 2026
View reviewed changes
Copy link
Collaborator

@a-nogikh a-nogikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ramosian-glider
ramosian-glider reviewed Jan 21, 2026
View reviewed changes
@6eanut 6eanut force-pushed the upstream/ifuzz branch 3 times, most recently from 570b5f1 to 48ecc14 Compare January 21, 2026 14:03
a-nogikh
a-nogikh reviewed Jan 22, 2026
View reviewed changes
Copy link
Collaborator

@a-nogikh a-nogikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment left

@6eanut
Copy link
Contributor Author

6eanut commented Jan 22, 2026 •
edited
Loading

@a-nogikh

Thanks for spotting the typo, fixed.

@6eanut 6eanut requested a review from a-nogikh January 22, 2026 11:51
@a-nogikh a-nogikh enabled auto-merge January 22, 2026 12:51
@a-nogikh a-nogikh added this pull request to the merge queue Jan 22, 2026
Merged via the queue into google:master with commit 82c9c08 Jan 22, 2026
18 checks passed
@6eanut 6eanut deleted the upstream/ifuzz branch January 22, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-nogikh a-nogikh a-nogikh approved these changes

@ramosian-glider ramosian-glider Awaiting requested review from ramosian-glider

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@6eanut @ramosian-glider @a-nogikh