-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improvements to agentic kernel build (better error logs) #6643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvyukov
reviewed
Jan 20, 2026
dvyukov
previously approved these changes
Jan 20, 2026
dvyukov
reviewed
Jan 20, 2026
dvyukov
reviewed
Jan 20, 2026
e1f63cb to
d4de433
Compare
dvyukov
previously approved these changes
Jan 23, 2026
Currently, when the kernel build fails, syz-aflow prints something along the line of: failed to run ["make" "KERNELVERSION=syzkaller" "KERNELRELEASE=syzkaller" "LOCALVERSION=-syzkaller" "-j" "36" "ARCH=x86_64" "CC=ccache clang" "LD=ld.lld" "O=workdir/cache/build/1c6c481ef478edbb8bf3afb9d73e9ff157b1a204" "bzImage" "compile_commands.json"]: exit status 2 Which is not particularly helpful, especially because the build directory gets immediately wiped out and the source directory does not contain the extracted .config which makes reproduction especially annoying. The -s flag makes make "silent", meaning that it only prints errors and not all successfully built compilation units, which keeps the logs more concise.
Currently, when an error occurs, it is printed as part of many Spans, in
my experience 3 times:
2026/01/20 19:38:59 finished action crash-reproducer (1/4) in 1.570202281s
results:
CrashReport:
error:
reproducer did not crash
2026/01/20 19:38:59 finished flow patching (0/0) in 1.571440624s
results:
error:
reproducer did not crash
reproducer did not crash
exit status 1
After this change it is only printed once:
2026/01/20 19:36:42 starting action crash-reproducer (1/4)...
reproducer did not crash
exit status 1
While we are at it, let's also make it a constant to make the intent clearer.
930f605 to
cfa1648
Compare
dvyukov
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.