Skip to content

Conversation

@FlorentRevest
Copy link
Collaborator

No description provided.

@dvyukov dvyukov self-assigned this Jan 20, 2026
dvyukov
dvyukov previously approved these changes Jan 20, 2026
@dvyukov dvyukov added the AI patching Feature requests and bugs related to AI-based kernel bug fix generation. label Jan 20, 2026
@FlorentRevest FlorentRevest changed the title Improvements to agentic kernel build (better error logs and target architecture identification) Improvements to agentic kernel build (better error logs) Jan 21, 2026
dvyukov
dvyukov previously approved these changes Jan 23, 2026
Currently, when the kernel build fails, syz-aflow prints something along
the line of:

failed to run ["make" "KERNELVERSION=syzkaller" "KERNELRELEASE=syzkaller" "LOCALVERSION=-syzkaller" "-j" "36"
 "ARCH=x86_64" "CC=ccache clang" "LD=ld.lld" "O=workdir/cache/build/1c6c481ef478edbb8bf3afb9d73e9ff157b1a204"
 "bzImage" "compile_commands.json"]: exit status 2

Which is not particularly helpful, especially because the build
directory gets immediately wiped out and the source directory does not
contain the extracted .config which makes reproduction especially
annoying.

The -s flag makes make "silent", meaning that it only prints errors and
not all successfully built compilation units, which keeps the logs more
concise.
Currently, when an error occurs, it is printed as part of many Spans, in
my experience 3 times:

2026/01/20 19:38:59 finished action crash-reproducer (1/4) in 1.570202281s
results:
        CrashReport:
error:
reproducer did not crash
2026/01/20 19:38:59 finished flow patching (0/0) in 1.571440624s
results:
error:
reproducer did not crash
reproducer did not crash
exit status 1

After this change it is only printed once:

2026/01/20 19:36:42 starting action crash-reproducer (1/4)...
reproducer did not crash
exit status 1
While we are at it, let's also make it a constant to make the intent
clearer.
@dvyukov dvyukov force-pushed the build-improvements branch from 930f605 to cfa1648 Compare January 23, 2026 08:26
@dvyukov dvyukov added this pull request to the merge queue Jan 23, 2026
Merged via the queue into google:master with commit f6897c6 Jan 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI patching Feature requests and bugs related to AI-based kernel bug fix generation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants