tools/clang/json: Escape strings properly #6650
Merged
+80
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Test please. pkg/codesearch/testdata has everything to test this end-to-end. to update all query files. |
FlorentRevest
force-pushed
the
json-string
branch
from
b98f4ca to
16339da
Compare
dvyukov
previously approved these changes
Jan 21, 2026
FlorentRevest
force-pushed
the
json-string
branch
4 times, most recently
from
7a57417 to
b4c5473
Compare
a-nogikh
previously approved these changes
Jan 23, 2026
When preparing a codesearch index, I encountered errors which I narrowed
down to lines like the following in the json output of codesearch:
"type": "void (void __attribute__((btf_type_tag("user")))*, const void *, size_t, size_t)",
After this change, the line gets formatted like this:
"type": "void (void __attribute__((btf_type_tag(\"user\")))*, const void *, size_t, size_t)",
This fixes the errors I encountered
FlorentRevest
force-pushed
the
json-string
branch
from
b4c5473 to
fa817a9
Compare
a-nogikh
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing a codesearch index, I encountered errors which I narrowed down to lines like the following in the json output of codesearch:
"type": "void (void attribute((btf_type_tag("user")))*, const void *, size_t, size_t)",
After this change, the line gets formatted like this:
"type": "void (void attribute((btf_type_tag("user")))*, const void *, size_t, size_t)",
This fixes the errors I encountered