Fix: chart generation robustness #3661
Merged
+271
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of chart generation by adding checks for encoding and data format before attempting to create a chart. The changes in AggregationResult.to_chart and BaseChart._get_chart_with_transform are well-implemented and prevent potential crashes. The accompanying new tests for these changes are thorough and correctly validate the new behavior.
However, I found an issue in the newly added tests for BaseAggregator. One of the tests seems to be based on an incorrect assumption about the behavior of BaseAggregator.__init__, which will cause the test to fail. Please see my detailed comment.
jkppr
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of chart generation within Timesketch aggregators and charts.