-
Notifications
You must be signed in to change notification settings - Fork 193
[DRT] Clarification on continuous pickup/dropoff value #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
LGTM |
The use of positive integer is problematic here, because it implies that 0 is not a valid value, i.e. you can't specify an immediate booking. |
@miklcct Positive integer is correct. 0 is not a valid value for these fields, because immediate booking is expressed with |
also For example, if a service requires booking between 72 hours before but can be made right until the trip starts, |
Deprecating the changes for "positive integer".
It does seem that this use case is not explicitly covered by the current spec. Currently, @miklcct Do you currently have a real-world example of such a reservation rule? (A link would be nice!) Perhaps we could modify the "same-day" description of |
Come to think of it, I have encountered a few services that are pretty flexible with their booking requirements (i.e., "if we have availability, we can pick you up now or you can reserve a month in advance") which we've had to model more restrictively due to the limitations of each booking type. I'd be OK with changing We need to keep |
If we want to move forward to these rule changes, it should probably exist as a separate PR. |
We recently also discovered the following booking use case in Barcelona: https://www.teisa-bus.com/pdf/pdf3_transport_demanda_pdf45.pdf
For this type of service, the most appropriate modeling under the current specification is likely be: As @miklcct mentioned, there may be cases where day=0 is needed. Agree that clarifications on booking rules could be addressed in a separate PR. I am going to open voting soon. |
I am opening a vote for this clarification. This clarification should not require extra implementation. Voting ends on 2025-03-07 at 23:59:59 UTC. |
+1 Trillium |
Apologies just returned from business trips and vacation. Since there were no objections in the previous vote, I will not make any changes and restart a new round of voting. Voting ends on 2025-04-07 at 23:59:59 UTC. @miklcct @gcamp @leonardehrenfried could you have a look at this clarification and vote? |
+1 Transit |
+1 Trillium |
+1 OpenTripPlanner |
+1 Aubin |
The vote passed on 2025-04-07 at 23:59:59 UTC. 4 votes in favour and no votes against. Votes came from: Thank you to everyone who participated! |
This PR includes only clarifications for DRT:
start_pickup_drop_off_window
/end_pickup_drop_off_window
, allow value1
for continuous_pickup/continuous_drop_off.