Skip to content

remove tflops measurement #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 2, 2026
Merged

remove tflops measurement #1171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions tunix/sft/peft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
from tunix.sft import profiler
from tunix.sft import progress_bar
from tunix.sft import sharding_utils
from tunix.sft import system_metrics_calculator
from tunix.sft import utils

_ModelInputT = Dict[str, ArrayLike]
Expand Down Expand Up @@ -233,7 +232,6 @@ def __init__(
self._mode: sft_metrics_logger.Mode = sft_metrics_logger.Mode.TRAIN
self._has_aux = False
self._pbar = None
self._flops_measured: bool = False

self._train_steps, self._restored_custom_metadata = (
self.checkpoint_manager.maybe_restore(
Expand Down Expand Up @@ -659,24 +657,6 @@ def train(
train_example, self.config.data_sharding_axis
)

if not self._flops_measured and not skip_jit:
self._flops_measured = True

tflops_per_step = system_metrics_calculator.measure_tflops_per_step(
train_step_fn=train_step,
model=self.model,
optimizer=self.optimizer,
train_example=train_example,
)
if tflops_per_step is not None:
self.metrics_logger.log(
self.metrics_prefix,
"tflops_per_step",
tflops_per_step,
self._mode,
0,
)

self._throttler.wait_for_next()
if self.training_hooks:
self.training_hooks.on_train_step_start(self)
Expand Down