Fix pre-commit mdformat hook dependency conflict - #2134
Open
howl-anderson wants to merge 1 commit into
Open
Conversation
The mdformat hook pins rev 1.0.0 but mdformat-gfm==0.3.5 requires mdformat<0.8.0, so the hook environment fails to install and every commit aborts with pip ResolutionImpossible. Bump mdformat-gfm to 1.0.0, which supports mdformat 1.0.0.
howl-anderson
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2,
tianshub and
wang2yn84
as code owners
September 8, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mdformatpre-commit hook is currently broken: the hook repo is pinned torev: 1.0.0, but the additional dependencymdformat-gfm==0.3.5requiresmdformat<0.8.0,>=0.7.5, so pip fails withResolutionImpossiblewhile building the hook environment and everygit commitin a fresh clone aborts:This bumps
mdformat-gfmto 1.0.0, which supports mdformat 1.0.0 (its requirement ismdformat>=0.7.5with no upper bound). Verified locally that the hook environment now installs and the hook runs.Note: since the hook has been uninstallable for a while, the repo's markdown files have drifted from mdformat's style — with the fixed hook,
pre-commit run mdformat --all-filescurrently reformats ~28 files. I left that out of this PR to keep it reviewable; happy to send the mechanical reformat as a follow-up if you'd like.