[codegen 1.5] Fix handling of Functions as Top in the presence of Procs #3696
+107
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where if the top block of a package was a function, but there were procs present in the package using global channels, the global channel stitching pass would accidentally displace the function while creating the stitching block. The `ScheduledBlockConversionPass` is also updated to apply the `module_name` from `CodegenOptions` to the converted block when the top is a function, ensuring that we have the correct block name. We found this while fixing issues in the BlockConversionPassPipeline tests that were causing certain tests to use Codegen 1.0 rather than Codegen 1.5. PiperOrigin-RevId: 857274640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Fix handling of Functions as Top in the presence of Procs
This fixes an issue where if the top block of a package was a function, but there were procs present in the package using global channels, the global channel stitching pass would accidentally displace the function while creating the stitching block.
The
ScheduledBlockConversionPassis also updated to apply themodule_namefromCodegenOptionsto the converted block when the top is a function, ensuring that we have the correct block name.We found this while fixing issues in the BlockConversionPassPipeline tests that were causing certain tests to use Codegen 1.0 rather than Codegen 1.5.