[opt] Simplify carry extraction pattern (prepending zero bit, adding, then slicing above the original MSb) #3731
+372
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the "ZeroExtendedBitsView" in this change seems useful until we come to stronger conclusions on canonical forms (i.e. zero_ext I think should be more canonical than concat as it's a more precise operator, but wouldn't want to make that a prereq).
bit_slice(add(zext(v), k), start=N, width=1)(carry-out ofv + k).bit_slice(...)becomes(k[N] ? ult(v, (2^N - (k mod 2^N))) : uge(v, (2^N - (k mod 2^N))))(and if(k mod 2^N) == 0, becomesliteral(k[N])).before:
which is:
after: