-
Notifications
You must be signed in to change notification settings - Fork 16
Update README.md with explanation of the design. #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
* The *source record spec* is a specification for well-formed input data. For a | ||
CSV-to-proto translation, this would be a schema for the CSV input: names and | ||
types of columns. | ||
* The *mapping definition* defines how to convert from the source record spec to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add more details about the mapping definition, including code pointers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't resolved yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's definitely resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if when someone marked a thread "resolved" if that action were clearer in the trail comments. Disputes over whether something is resolved are common. Even more common is the need for the reviewer to check that something was actually resolved. This UI seems to bury the resolved comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI is not showing it, but I have been alternating clicking "resolve conversation" and "unresolve conversation" in both of my accounts. Those actions are hidden.
* The *mapping definition* defines how to convert from the source record spec to | ||
the destination proto type. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's describe the code generation process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
No description provided.