[tests] Annotate UI test files with error requirements#3000
Merged
Conversation
Contributor
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of the UI test suite by introducing a comprehensive system of annotations within test files. These annotations precisely specify the expected compiler diagnostic output, including error messages and line numbers, for various Rust toolchain revisions. This ensures consistent and accurate validation of compiler behavior, particularly for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3000 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 20 20
Lines 6057 6057
=======================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
approved these changes
Feb 6, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a large but valuable refactoring of the UI tests. It annotates many test files with specific error requirements for different Rust toolchains (MSRV, stable, and nightly). This makes the expected outcomes of tests explicit and improves their maintainability. The changes are systematic and appear correct, including the necessary updates to the test runner configuration and the expected error output files. I don't have any specific issues to raise; this is a solid improvement to the test suite.
joshlf
force-pushed
the
G3638fc706fe75313ba5202a53db61e78b5243a1f
branch
from
8adbd58 to
1f03f47
Compare
joshlf
force-pushed
the
G89ee46d6a1d97f48811d710599b089f486c85717
branch
from
06ac251 to
20a5e50
Compare
Base automatically changed from
G89ee46d6a1d97f48811d710599b089f486c85717
to
main
February 6, 2026 20:25
joshlf
force-pushed
the
G3638fc706fe75313ba5202a53db61e78b5243a1f
branch
3 times, most recently
from
7d9cf02 to
eb4b425
Compare
Makes progress on #2999 gherrit-pr-id: G3638fc706fe75313ba5202a53db61e78b5243a1f
joshlf
force-pushed
the
G3638fc706fe75313ba5202a53db61e78b5243a1f
branch
from
eb4b425 to
f33f472
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
Makes progress on #2999 gherrit-pr-id: G3638fc706fe75313ba5202a53db61e78b5243a1f
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes progress on #2999
Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G3638fc706fe75313ba5202a53db61e78b5243a1f && git checkout -b pr-G3638fc706fe75313ba5202a53db61e78b5243a1f FETCH_HEADCheckout
git fetch origin refs/heads/G3638fc706fe75313ba5202a53db61e78b5243a1f && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G3638fc706fe75313ba5202a53db61e78b5243a1f && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.