fix: global types support for jsr.io#1409
Open
CodeMaverick-143 wants to merge 1 commit intogoogle:mainfrom
Open
fix: global types support for jsr.io#1409CodeMaverick-143 wants to merge 1 commit intogoogle:mainfrom
CodeMaverick-143 wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JSR global types support (addresses TODO in
src/globals.ts).Previously, proper type definitions for globals like
$,fs, andpathwere missing when importing from JSR, causing type errors in consumer projects and failures duringjsr publish. I've added the missingdeclare globalblock tosrc/globals-jsr.ts, adjustedtsconfig.jsonto avoid duplicate identifier conflicts during the build, and updated the JSR integration tests to allow global augmentations (which are necessary but flagged as "slow types" by JSR).npm buildbefore committing and verified the bundle updates correctly.run testand confirmed all tests succeed (specificallynpm run test:typesandnpm run test:jsr).