Skip to content

Replace View.GONE with View.INVISIBLE for banner ads. #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 10, 2026
Merged

Replace View.GONE with View.INVISIBLE for banner ads. #4305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...s/Android/GoogleMobileAdsPlugin.androidlib/src/main/java/com/google/unity/ads/Banner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ protected void createAdView(final String publisherId, final AdSize adSize) {
adView.setBackgroundColor(Color.TRANSPARENT);
adView.setAdUnitId(publisherId);
adView.setAdSize(adSize);
adView.setVisibility(View.GONE);
adView.setVisibility(View.INVISIBLE);
adView.setDescendantFocusability(ViewGroup.FOCUS_BLOCK_DESCENDANTS);
unityPlayerActivity.addContentView(adView, getLayoutParams());
adView.setAdListener(
Expand Down Expand Up @@ -346,15 +346,15 @@ public void run() {
});
}

/** Sets the {@link AdView} to be gone. */
/** Sets the {@link AdView} to be invisible. */
public void hide() {
unityPlayerActivity.runOnUiThread(
new Runnable() {
@Override
public void run() {
Log.d(PluginUtils.LOGTAG, "Calling hide() on Android");
hidden = true;
adView.setVisibility(View.GONE);
adView.setVisibility(View.INVISIBLE);
adView.pause();
}
});
Expand Down
2 changes: 1 addition & 1 deletion ...gin.androidlib/src/main/java/com/google/unity/ads/admanager/UnityAdManagerBannerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected void createAdView(final String publisherId, final AdSize adSize) {
adView.setBackgroundColor(Color.TRANSPARENT);
adView.setAdUnitId(publisherId);
adView.setAdSize(adSize);
adView.setVisibility(View.GONE);
adView.setVisibility(View.INVISIBLE);
adView.setDescendantFocusability(ViewGroup.FOCUS_BLOCK_DESCENDANTS);
unityPlayerActivity.addContentView(adView, getLayoutParams());
adView.setAdListener(
Expand Down
4 changes: 2 additions & 2 deletions ...droid/GoogleMobileAdsPlugin.androidlib/src/test/java/com/google/unity/ads/BannerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ public void show_setsAdViewVisibilityToVisible() {
}

@Test
public void hide_setsAdViewVisibilityToGone() {
public void hide_setsAdViewVisibilityToInvisible() {
banner.hide();
assertThat(banner.adView.getVisibility()).isEqualTo(View.GONE);
assertThat(banner.adView.getVisibility()).isEqualTo(View.INVISIBLE);
}

@Test
Expand Down