test : add integration test for SQLSpecialColumns API - #1643
Draft
Anshu6250 wants to merge 1 commit into
Draft
Conversation
Anshu6250
force-pushed
the
SQLSpecialColumns_integration_tests
branch
2 times, most recently
from
August 25, 2026 12:19
c255959 to
f9e7324
Compare
Anshu6250
changed the title
Anshu6250
changed the title
Anshu6250
changed the title
Anshu6250
force-pushed
the
SQLSpecialColumns_integration_tests
branch
from
August 25, 2026 13:29
f9e7324 to
7839a25
Compare
| conn, SQL_BEST_ROWID, kDatasetName, kCatalogDatasetTableWithPK); | ||
|
|
||
| // existing driver returns an empty result set for SQL_BEST_ROWID. | ||
| EXPECT_TRUE(special_columns.empty()); |
Collaborator
There was a problem hiding this comment.
why is it empty for every test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR establishes the integration testing baseline for the
SQLSpecialColumnsAPI against the existing driver, in preparation for its implementation in the new BQ driver.Key Changes:
Catalog::GetSpecialColumnshelper to fetch and map special column metadata.catalog_test.ccto verify the existing driver's behavior forSQL_BEST_ROWID(with and without primary keys) andSQL_ROWVER.StatementTest.SQLSpecialColumns_VerifyMetadatato strictly ensure the returned schema matches the 8 standard columns defined by the ODBC 3.8 specification.pipeline: link