feat: add logging support to generated clients #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
added
the
do not merge
Member
Author
|
Requires googleapis/gax-go#380 and googleapis/google-api-go-client#2854 be rolled out to all clients first |
codyoss
force-pushed
the
slog-logging
branch
2 times, most recently
from
cacc368 to
b357120
Compare
codyoss
force-pushed
the
slog-logging
branch
7 times, most recently
from
197ad23 to
87dcdfc
Compare
codyoss
removed
the
do not merge
codyoss
added a commit
to codyoss/google-cloud-go
that referenced
this pull request
Dec 4, 2024
This is required to land the logging generated changes staged in googleapis/gapic-generator-go#1577.
quartzmo
reviewed
Dec 4, 2024
quartzmo
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change instruments all generated clients with logging. In order to reduce the amount of codegen this would take I refactored some common logic about executing the request and parsing the response into a common helper. This change should reduce LoC for generated clients as a nice side-effect.