fix: have a helper that returns a http Response as well #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a rpc returns an httpBody, see https://pkg.go.dev/google.golang.org/genproto/googleapis/api/httpbody#HttpBody, we need to return a response from the helper so we can examine the headers.
quartzmo
reviewed
Dec 9, 2024
| p("") | ||
| p(" buf, err := executeHTTPRequest(ctx, c.httpClient, httpReq, c.logger, %s, %q)", logBody, m.GetName()) | ||
| if isHTTPBodyMessage { | ||
| p(" buf, httpRsp, err := executeHTTPRequestWithResponse(ctx, c.httpClient, httpReq, c.logger, %s, %q)", logBody, m.GetName()) |
Member
There was a problem hiding this comment.
How does httpRsp get used in the client?
Member
Author
There was a problem hiding this comment.
I would direct you to the updated generated file: internal/gengapic/testdata/rest_HttpBodyRPC.want
Member
There was a problem hiding this comment.
Thanks, when I look at the whole file I see the usage:
if headers := httpRsp.Header; len(headers["Content-Type"]) > 0 {
resp.ContentType = headers["Content-Type"][0]
}
But it doesn't show up in the diff. Odd that this usage existed before.
quartzmo
approved these changes
Dec 9, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.49.3](https://togithub.com/googleapis/gapic-generator-go/compare/v0.49.2...v0.49.3) (2024-12-09) ### Bug Fixes * Have a helper that returns a http Response as well ([#1594](https://togithub.com/googleapis/gapic-generator-go/issues/1594)) ([b947c65](https://togithub.com/googleapis/gapic-generator-go/commit/b947c6511043f038190ffb6480a4b4579d9f635b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a rpc returns an httpBody, see
https://pkg.go.dev/google.golang.org/genproto/googleapis/api/httpbody#HttpBody, we need to return a response from the helper so we can examine the headers.