Skip to content

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Jan 15, 2026

This PR is a a larger diff, but conceptually it's straightforward:

  • rename the options struct to generatorConfig
  • rename the opts field in the generator type (main driver for the code generator) to cfg.
  • newOptionsFromParams() -> configFromRequest()
  • consolidate some of the config in the generator into this new generatorConfig struct, namely the API service config and the gRPC service config
  • handle loading the grpc and api service configs during option processing. Currently we do this later in the generator setup process, and end up carrying around these file paths unnecessarily.
  • update references

The ongoing goal is to get the generator have a more structured application model, and less commingling of random config and runtime state fields all over the place. I would also like to get closer to a world where config is immutable once built, so that the separation between config and state gets clearer.

@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 15, 2026
@shollyman shollyman marked this pull request as ready for review January 15, 2026 22:59
@shollyman shollyman requested a review from a team as a code owner January 15, 2026 22:59
@shollyman shollyman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 15, 2026
@shollyman shollyman merged commit 1fc62ac into googleapis:main Jan 22, 2026
8 checks passed
@shollyman shollyman deleted the better-config branch January 22, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants