feat(tools/conversational-analytics): Allow optional dataAgent by efantasia · Pull Request #2490 · googleapis/genai-toolbox

efantasia · 2026-02-17T23:40:51Z

Description

Modifies both the bigquery-conversational-analytics and looker-conversational-analytics tools to accept an optional dataAgent configuration parameter. The Data Agent provides additional context and settings: https://docs.cloud.google.com/gemini/docs/conversational-analytics-api/build-agent-http#create_a_data_agent

PR Checklist

Make sure you reviewed
CONTRIBUTING.md
Make sure to open an issue as a
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

gemini-code-assist · 2026-02-17T23:41:08Z

Summary of Changes

Hello @efantasia, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the BigQuery and Looker conversational analytics tools by introducing an optional dataAgent configuration. This allows users to leverage external data agents for providing context to the conversational analytics API, offering a more flexible and powerful way to interact with data compared to solely relying on inline context. The change involves updating tool configurations, API payload structures, and relevant documentation.

Highlights

Optional Data Agent Support: Introduced an optional dataAgent parameter for both BigQuery and Looker conversational analytics tools, allowing external context to be provided to the conversational analytics API.
API Payload Flexibility: Modified the internal Go structs and logic to dynamically construct the API payload, choosing between InlineContext or DataAgentContext based on the presence of the dataAgent.
Documentation Updates: Expanded documentation for both BigQuery and Looker conversational analytics tools to guide users on configuring and utilizing the new dataAgent feature.

Changelog

docs/en/resources/tools/bigquery/bigquery-conversational-analytics.md
- Added a new section explaining how to use a Data Agent.
- Updated the reference table to include the optional dataAgent field.
docs/en/resources/tools/looker/looker-conversational-analytics.md
- Added a new section explaining how to use a Data Agent.
- Updated the reference table to include the optional dataAgent field.
internal/tools/bigquery/bigqueryconversationalanalytics/bigqueryconversationalanalytics.go
- Introduced a new DataAgentContext struct to encapsulate data agent information.
- Modified the CAPayload struct to allow for either an optional InlineContext or DataAgentContext.
- Added a DataAgent field to the Config struct to store the data agent resource name.
- Updated the Invoke method to conditionally populate the CAPayload with DataAgentContext if a data agent is configured, otherwise using InlineContext.
internal/tools/looker/lookerconversationalanalytics/lookerconversationalanalytics.go
- Introduced a new DataAgentContext struct to encapsulate data agent information.
- Modified the CAPayload struct to allow for either an optional InlineContext or DataAgentContext.
- Added a DataAgent field to the Config struct to store the data agent resource name.
- Updated the Invoke method to conditionally populate the CAPayload with DataAgentContext if a data agent is configured, otherwise using InlineContext.

Activity

No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces an optional dataAgent parameter for the bigquery-conversational-analytics and looker-conversational-analytics tools, allowing users to leverage pre-configured data agents for context. While the implementation correctly handles conditional logic for the API payload, a significant security concern exists: the BigQuery tool is vulnerable to prompt injection due to concatenating instructions with user input. It is strongly recommended to update the BigQuery tool to use the systemInstruction field, aligning with the Looker tool's more secure approach. Also, a minor typo was noted in the documentation.

internal/tools/bigquery/bigqueryconversationalanalytics/bigqueryconversationalanalytics.go

docs/en/resources/tools/looker/looker-conversational-analytics.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

drstrangelooker · 2026-02-19T16:53:58Z

/gcbrun

drstrangelooker · 2026-02-19T16:57:05Z

/gcbrun

efantasia · 2026-02-19T17:06:03Z

Hi @drstrangelooker - thanks for reviewing! This is my first contribution here. JFYI I've tested the dataAgent with BigQuery but do not have a Looker Data Agent to test against.

drstrangelooker · 2026-02-20T17:16:22Z

/gcbrun

drstrangelooker

I fixed the lint issues. LGTM

duwenxin99 · 2026-03-08T19:22:42Z

/gcbrun

duwenxin99 · 2026-03-17T03:49:12Z

Hi @Genesis929, could you review this PR for the BQ change? Thanks!

Genesis929

LGTM except maybe we need integration test. Meanwhile may need @shobsi to approve this for bigquery?

drstrangelooker · 2026-03-17T22:17:26Z

/gcbrun

github-actions · 2026-03-17T22:30:07Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2490/

drstrangelooker · 2026-03-17T22:32:09Z

/gcbrun

github-actions · 2026-03-17T22:37:20Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2490/

drstrangelooker · 2026-03-23T16:56:43Z

/gcbrun

github-actions · 2026-03-23T17:01:28Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2490/

drstrangelooker · 2026-03-23T18:03:31Z

/gcbrun

github-actions · 2026-03-23T18:08:27Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2490/

drstrangelooker · 2026-03-23T18:29:14Z

/gcbrun

drstrangelooker · 2026-03-23T18:50:33Z

someone from @googleapis/toolbox-bigquery-team needs to approve now

github-actions · 2026-03-24T14:33:49Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2490/

feat(tools/conversational-analytics): Allow optional dataAgent

2252ccb

efantasia requested review from a team February 17, 2026 23:40

blunderbuss-gcf bot assigned duwenxin99 Feb 17, 2026

gemini-code-assist bot reviewed Feb 17, 2026

View reviewed changes

internal/tools/bigquery/bigqueryconversationalanalytics/bigqueryconversationalanalytics.go Outdated Show resolved Hide resolved

docs/en/resources/tools/looker/looker-conversational-analytics.md Outdated Show resolved Hide resolved

Update docs/en/resources/tools/looker/looker-conversational-analytics.md

65f3f6f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Merge branch 'main' into ef/ca-data-agent

856c3e4

Incorporate code assist feedback

b0c30ba

drstrangelooker added 2 commits February 20, 2026 12:15

Merge branch 'main' into ef/ca-data-agent

dce3a75

fix lint issues

c0a3416

drstrangelooker added the tests: run Label to trigger Github Action tests. label Feb 20, 2026

github-actions bot removed the tests: run Label to trigger Github Action tests. label Feb 20, 2026

drstrangelooker approved these changes Feb 20, 2026

View reviewed changes

duwenxin99 approved these changes Mar 8, 2026

View reviewed changes

Merge branch 'main' into ef/ca-data-agent

1eb8e43

duwenxin99 requested review from a team as code owners March 8, 2026 19:22

duwenxin99 added the tests: run Label to trigger Github Action tests. label Mar 8, 2026

duwenxin99 enabled auto-merge (squash) March 8, 2026 19:22

github-actions bot removed the tests: run Label to trigger Github Action tests. label Mar 8, 2026

Merge branch 'main' into ef/ca-data-agent

b9bec36

Genesis929 approved these changes Mar 17, 2026

View reviewed changes

Merge branch 'main' into ef/ca-data-agent

80605aa

Merge branch 'main' into ef/ca-data-agent

e28dfdf

Merge branch 'main' into ef/ca-data-agent

3a3eb67

Merge branch 'main' into ef/ca-data-agent

b9aba4e

drstrangelooker approved these changes Mar 23, 2026

View reviewed changes

Merge branch 'main' into ef/ca-data-agent

6940450

duwenxin99 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 24, 2026

Merge branch 'main' into ef/ca-data-agent

de411b1

Conversation

efantasia commented Feb 17, 2026

Description

PR Checklist

Uh oh!

gemini-code-assist bot commented Feb 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

drstrangelooker commented Feb 19, 2026

Uh oh!

drstrangelooker commented Feb 19, 2026

Uh oh!

efantasia commented Feb 19, 2026

Uh oh!

drstrangelooker commented Feb 20, 2026

Uh oh!

drstrangelooker left a comment

Choose a reason for hiding this comment

Uh oh!

duwenxin99 commented Mar 8, 2026

Uh oh!

duwenxin99 commented Mar 17, 2026

Uh oh!

Genesis929 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drstrangelooker commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

drstrangelooker commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

drstrangelooker commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

drstrangelooker commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

drstrangelooker commented Mar 23, 2026

Uh oh!

drstrangelooker commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Genesis929 left a comment •

edited

Loading