Skip to content

test(spannersql): add semantic search integration tests and docs#2889

Open
duwenxin99 wants to merge 3 commits intomainfrom
feat/spanner-semantic-search
Open

test(spannersql): add semantic search integration tests and docs#2889
duwenxin99 wants to merge 3 commits intomainfrom
feat/spanner-semantic-search

Conversation

@duwenxin99
Copy link
Copy Markdown
Contributor

@duwenxin99 duwenxin99 commented Mar 30, 2026 •
edited
Loading

Part of #2415

@duwenxin99 duwenxin99 requested review from a team as code owners March 30, 2026 01:51
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests for Spanner semantic search by adding logic to create a temporary vector table and configure the semantic search tool. Feedback was provided to enhance the test's realism and performance by creating a vector index on the embedding column and utilizing the ANN_SEARCH function for more idiomatic query execution.

@duwenxin99 duwenxin99 changed the title feat(source/spanner): add semantic search integration tests test(source/spanner): add semantic search integration tests Mar 30, 2026
@duwenxin99 duwenxin99 mentioned this pull request Mar 30, 2026
Open
1 task
@duwenxin99 duwenxin99 linked an issue Mar 30, 2026 that may be closed by this pull request
Support all vector databases #2415
Open
1 task
@duwenxin99 duwenxin99 removed a link to an issue Mar 30, 2026
Support all vector databases #2415
Open
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

🚀 Cloudflare Preview Ready!

🔎 View Preview: https://pr-2889.toolbox-docs-6xc.pages.dev

(Note: Subsequent pushes to this PR will automatically update the preview at this same URL)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2889/

@duwenxin99 duwenxin99 changed the title test(source/spanner): add semantic search integration tests test(tools/spanner): add semantic search integration tests and docs Mar 30, 2026
@duwenxin99 duwenxin99 changed the title test(tools/spanner): add semantic search integration tests and docs test(spanner): add semantic search integration tests and docs Mar 30, 2026
@duwenxin99 duwenxin99 changed the title test(spanner): add semantic search integration tests and docs test(spannersql): add semantic search integration tests and docs Mar 30, 2026
averikitsch
averikitsch reviewed Apr 1, 2026
View reviewed changes
tests/spanner/spanner_integration_test.go
Copy link
Copy Markdown
Contributor

@averikitsch averikitsch Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test against both googlesql and postgresql sources?

TanmayVartak
TanmayVartak approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@TanmayVartak TanmayVartak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated formatting changes. Spanner related code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch left review comments

@TanmayVartak TanmayVartak TanmayVartak approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Yuan325 Yuan325

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@duwenxin99 @averikitsch @TanmayVartak @Yuan325