feat(tools/bigquerysql): add semantic search support#2890
Open
duwenxin99 wants to merge 9 commits intomainfrom
Open
feat(tools/bigquerysql): add semantic search support#2890duwenxin99 wants to merge 9 commits intomainfrom
duwenxin99 wants to merge 9 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for vector parameters in BigQuery SQL tools by handling []float32 slices and converting them to []float64 arrays for compatibility with the BigQuery Go client. It also adds integration tests for semantic search, including a new vector table setup and test cases for vector-based queries. I have no feedback to provide.
duwenxin99
force-pushed
the
feat/bigquery-semantic-search
branch
from
54f5e89 to
01ce7c3
Compare
duwenxin99
force-pushed
the
feat/bigquery-semantic-search
branch
from
3c26329 to
a6e31ae
Compare
duwenxin99
changed the title
Contributor
|
🚀 Cloudflare Preview Ready! 🔎 View Preview: https://pr-2890.toolbox-docs-6xc.pages.dev (Note: Subsequent pushes to this PR will automatically update the preview at this same URL) |
Contributor
duwenxin99
changed the title
duwenxin99
changed the title
duwenxin99
changed the title
averikitsch
reviewed
Apr 1, 2026
|
|
||
| arrayValues[i] = &bigqueryrestapi.QueryParameterValue{ | ||
| Value: fmt.Sprintf("%v", sliceVal.Index(i).Interface()), | ||
| Value: fmt.Sprintf(format, val), |
Contributor
There was a problem hiding this comment.
strconv.FormatFloat may have better performance here. I worry about the precision loss of converting this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.