test(elasticsearch): add integration tests for semantic vector search#2891
Open
duwenxin99 wants to merge 3 commits intomainfrom
Open
test(elasticsearch): add integration tests for semantic vector search#2891duwenxin99 wants to merge 3 commits intomainfrom
duwenxin99 wants to merge 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds semantic search capabilities to the Elasticsearch integration. It updates the CI pipeline to include an API_KEY secret and modifies integration tests to support vector-based indexing and ES|QL semantic search queries. The review feedback suggests refining error handling during index creation to specifically target existing resources and using strings.Repeat to simplify the construction of test vector strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2415