fix(tests/spanner): implement resource cleanup for graphs and tables#2904
Open
NirajNandre wants to merge 5 commits intogoogleapis:mainfrom
Open
fix(tests/spanner): implement resource cleanup for graphs and tables#2904NirajNandre wants to merge 5 commits intogoogleapis:mainfrom
NirajNandre wants to merge 5 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a centralized Spanner resource cleanup mechanism for integration tests. It adds a CleanupSpannerResources utility in tests/common.go and refactors TestSpannerToolEndpoints to use t.Cleanup with a unique identifier for resource isolation. The review feedback suggests ensuring the correct drop order for interleaved tables by sorting the schema query, implementing timeouts for cleanup contexts to prevent potential hangs, and using IF EXISTS in DDL statements to ensure idempotency.
Contributor
|
/gcbrun |
anubhav756
force-pushed
the
fix/spanner-resource-cleanup
branch
from
d7244d6 to
3744435
Compare
Contributor
|
/gcbrun |
NirajNandre
force-pushed
the
fix/spanner-resource-cleanup
branch
from
3744435 to
75e928a
Compare
Contributor
|
/gcbrun |
2 similar comments
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
NirajNandre
force-pushed
the
fix/spanner-resource-cleanup
branch
2 times, most recently
from
38420ef to
8cb5311
Compare
Contributor
|
/gcbrun |
NirajNandre
force-pushed
the
fix/spanner-resource-cleanup
branch
from
c21480c to
e9b8bc8
Compare
Contributor
|
/gcbrun |
anubhav756
force-pushed
the
fix/spanner-resource-cleanup
branch
from
6fb52e9 to
1c5becf
Compare
NirajNandre
force-pushed
the
fix/spanner-resource-cleanup
branch
from
1c5becf to
c8f57ab
Compare
anubhav756
force-pushed
the
fix/spanner-resource-cleanup
branch
from
c8f57ab to
d83886b
Compare
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a robust cleanup mechanism for Spanner integration tests to address resource leakage and the 16-graph bottleneck issue.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>