Skip to content

fix(tests/spanner): Fix swallowing of spanner integration test failures #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anubhav756 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(tests/spanner): Fix swallowing of spanner integration test failures #2908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/integration.cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ steps:
.ci/test_with_coverage.sh \
"Spanner" \
spanner \
spanner || echo "Integration tests failed."
spanner || { echo "Integration tests failed."; exit 1; }
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The explicit error handling || { echo ...; exit 1; } is redundant here. In a Cloud Build args block using bash -c, the exit code of the shell is determined by the last command executed in the script. Since this test command is the final operation in its branch of the if statement, the step will naturally fail if the tests fail. Removing this logic would make the Spanner step consistent with all other integration test steps in this file (e.g., cloud-sql-pg, alloydb, bigquery, etc.), which simply call the test script directly.

            spanner

else
echo "No relevant changes for Spanner. Skipping shard."
exit 0
Expand Down
Loading