fix(skill): fix skill generation template#2914
Merged
twishabansal merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the getToolboxPath function in cmd/internal/skills/generator.go to ensure cross-platform compatibility. It now detects if the operating system is Windows and appends the .exe extension to the toolbox binary path accordingly. I have no feedback to provide.
twishabansal
approved these changes
Apr 1, 2026
Contributor
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
github-actions bot
pushed a commit
to sumeetdhingra-google/genai-toolbox
that referenced
this pull request
Apr 1, 2026
This PR fixes the skill generation template to properly locate the toolbox.exe for windows a01a15e
github-actions bot
pushed a commit
to sumeetdhingra-google/genai-toolbox
that referenced
this pull request
Apr 1, 2026
This PR fixes the skill generation template to properly locate the toolbox.exe for windows a01a15e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the skill generation template to properly locate the toolbox.exe for windows