feat: Add Codex CLI plugin manifest#2939
feat: Add Codex CLI plugin manifest#2939internet-dot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces the initial configuration for the GenAI Toolbox Codex plugin, including the plugin manifest, MCP server configuration, and skill documentation. Feedback suggests adding the -y flag to the npx command in .mcp.json to ensure non-interactive execution. Additionally, several updates are recommended to align the plugin's display name and documentation with the project's rebranding to 'MCP Toolbox for Databases' for consistency.
| "args": [ | ||
| "@toolbox-sdk/server", | ||
| "--config", | ||
| "tools.yaml" | ||
| ] |
There was a problem hiding this comment.
Consider adding the -y flag to the npx command. This ensures that npx runs non-interactively and automatically accepts the installation of the @toolbox-sdk/server package if it's not already present in the environment. This is a best practice for plugin manifests to avoid hanging in non-interactive shells, and it is consistent with the examples provided in the project's README (line 82).
"args": [
"-y",
"@toolbox-sdk/server",
"--config",
"tools.yaml"
]| "mcpServers": "./.mcp.json", | ||
| "skills": "./skills/", | ||
| "interface": { | ||
| "displayName": "GenAI Toolbox", |
There was a problem hiding this comment.
| # GenAI Toolbox for Codex | ||
|
|
||
| Use GenAI Toolbox from Codex via MCP. | ||
|
|
||
| ## When to use | ||
| - When you need genai-toolbox capabilities in your Codex workflow |
There was a problem hiding this comment.
Update the skill title and description to use "MCP Toolbox" instead of "GenAI Toolbox" for consistency with the current project branding and the rest of the documentation.
| # GenAI Toolbox for Codex | |
| Use GenAI Toolbox from Codex via MCP. | |
| ## When to use | |
| - When you need genai-toolbox capabilities in your Codex workflow | |
| # MCP Toolbox for Codex | |
| Use MCP Toolbox from Codex via MCP. | |
| ## When to use | |
| - When you need MCP Toolbox capabilities in your Codex workflow |
Adds a Codex CLI plugin manifest.
What this adds: .codex-plugin/plugin.json, .mcp.json, skills/SKILL.md
Related: awesome-codex-plugins | codex-plugin-scanner