Skip to content

chore: run gofumpt + modernize#527

Open
andreynering wants to merge 2 commits intogoogleapis:mainfrom
charmbracelet:fmt-modernize
Open

chore: run gofumpt + modernize#527
andreynering wants to merge 2 commits intogoogleapis:mainfrom
charmbracelet:fmt-modernize

Conversation

@andreynering
Copy link
Copy Markdown

@andreynering andreynering commented Sep 23, 2025

This PR adds two commits with formatting / linting changes only. Behavior should be intact.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Sep 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@andreynering andreynering force-pushed the fmt-modernize branch 2 times, most recently from 75565dc to f1ca5de Compare September 24, 2025 12:46
@Sivasankaran25 Sivasankaran25 self-assigned this Sep 26, 2025
@Sivasankaran25
Copy link
Copy Markdown
Collaborator

Hi @andreynering
Thanks for your contributions!
Kindly update the description.
Thank you!

@andreynering
Copy link
Copy Markdown
Author

andreynering commented Sep 26, 2025

Hi @Sivasankaran25. Thanks for taking a look!

I added a description linking the tool in ran in the codebase.

I also rebased to fix a conflict.

@qiaodev
Copy link
Copy Markdown
Contributor

qiaodev commented Oct 6, 2025

Hi @andreynering

May I know the exact command you ran for this PR? Because many files are auto generated and I need to implement the command in our internal generator as well.

Thanks.

@andreynering
Copy link
Copy Markdown
Author

@qiaodev

  • gofumpt -w .
  • modernize -fix -test ./...

@qiaodev
Copy link
Copy Markdown
Contributor

qiaodev commented Oct 15, 2025

Actually this is non-trivial to support running gofumpt and modernize in google internal code base.

@andreynering Is it important? Or nice to have? Thanks

@andreynering
Copy link
Copy Markdown
Author

@qiaodev It's up to you, but my personal opinion is that gofumpt is quite popular, so it'd be nice to use it.

The reason I cared opening this PR is because my editor runs gofumpt by default on every save, so I got unrelated changes when working on #526.

Of course, I can temporarily disable that in this codebase if I have no other option.

@Sivasankaran25 Sivasankaran25 added the api:gemini-api Issues related to Gemini API label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:gemini-api Issues related to Gemini API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants