Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
75565dc to
f1ca5de
Compare
|
Hi @andreynering |
58194c0 to
483534f
Compare
|
Hi @Sivasankaran25. Thanks for taking a look! I added a description linking the tool in ran in the codebase. I also rebased to fix a conflict. |
|
May I know the exact command you ran for this PR? Because many files are auto generated and I need to implement the command in our internal generator as well. Thanks. |
|
483534f to
be9b656
Compare
|
Actually this is non-trivial to support running gofumpt and modernize in google internal code base. @andreynering Is it important? Or nice to have? Thanks |
|
@qiaodev It's up to you, but my personal opinion is that The reason I cared opening this PR is because my editor runs Of course, I can temporarily disable that in this codebase if I have no other option. |
This PR adds two commits with formatting / linting changes only. Behavior should be intact.