refactor: cleanup redundancies in actions workflow#627
Open
ClaytonNorthey92 wants to merge 1 commit intogoogleapis:mainfrom
Open
refactor: cleanup redundancies in actions workflow#627ClaytonNorthey92 wants to merge 1 commit intogoogleapis:mainfrom
ClaytonNorthey92 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ClaytonNorthey92
force-pushed
the
clayton/workflow-cleanup
branch
from
bbd69b0 to
22d3158
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
force-pushed
the
clayton/workflow-cleanup
branch
3 times, most recently
from
9099718 to
c98161a
Compare
ClaytonNorthey92
force-pushed
the
clayton/workflow-cleanup
branch
3 times, most recently
from
f7070ff to
ab0c78e
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
force-pushed
the
clayton/workflow-cleanup
branch
from
ab0c78e to
b16df68
Compare
update the .workflows/test.yml file to remove (most) redudancies in the .workflows/test.yml file... * add matrix entries for go versions 1.23, 1.24 * add matrix entries for each "latest" os (macos, linux, windows) * use this matrix for both testing and linting, but keep jobs separate * update golangci-lint timeout to 120s as it was timing out on windows
ClaytonNorthey92
force-pushed
the
clayton/workflow-cleanup
branch
from
b16df68 to
7ac2362
Compare
Author
|
hey @sararob @Sivasankaran25 --sorry to bother you both--could I get some feedback on this PR? since it's an actions change, here is an example of it running on my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the .workflows/test.yml file to remove (most) redudancies
in the .workflows/test.yml file...