chore(.gemini): add GEMINI.md context file#3385
Draft
quartzmo wants to merge 1 commit intogoogleapis:mainfrom
Draft
chore(.gemini): add GEMINI.md context file#3385quartzmo wants to merge 1 commit intogoogleapis:mainfrom
quartzmo wants to merge 1 commit intogoogleapis:mainfrom
Conversation
westarle
approved these changes
Nov 26, 2025
westarle
left a comment
westarle
left a comment
There was a problem hiding this comment.
I had similar thoughts as googleapis/google-cloud-go#13408
| * **Transport Creation (`transport/http/dial.go`):** This is the **critical chokepoint** for all HTTP clients. `NewClient` calls `dial`, which constructs the `http.Client`. | ||
| * **Instrumentation Point:** This is the exact location to wrap the `http.Transport` (e.g., with OpenTelemetry) or inject middleware. | ||
| * **Configuration:** Users configure clients using `option.ClientOption` (found in `option/`). | ||
| * **`option.WithTracerProvider`:** This option flows into `dial.go` and determines the tracing provider. |
There was a problem hiding this comment.
Are all these details helpful outside the scope of work on tracing? My only concern is that this is sort of a "partial" architecture description that might limit the focus.
If the real meat of the clients is all in dial and ClientOption then this makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.