Skip to content

fix: merge duplicate x-goog-request-params header#3547

Merged
cpriti-os merged 6 commits intomainfrom
fix-duplicate-x-goog-request-params-4611007834348080142
Mar 30, 2026
Merged

fix: merge duplicate x-goog-request-params header#3547
cpriti-os merged 6 commits intomainfrom
fix-duplicate-x-goog-request-params-4611007834348080142

Conversation

@cpriti-os
Copy link
Copy Markdown
Contributor

This change fixes an issue where multiple x-goog-request-params headers were being sent on API requests, leading to "Invalid Bucket name errors". The headers are now correctly merged using an ampersand (&), similar to how x-goog-api-client handles multiple values.


PR created automatically by Jules for task 4611007834348080142 started by @cpriti-os

Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
@cpriti-os cpriti-os requested a review from a team as a code owner March 20, 2026 12:41
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cpriti-os cpriti-os marked this pull request as draft March 20, 2026 12:43
Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
@cpriti-os cpriti-os changed the title Fix duplicate x-goog-request-params header fix: merge duplicate x-goog-request-params header Mar 20, 2026
@cpriti-os cpriti-os marked this pull request as ready for review March 20, 2026 13:06
@cpriti-os cpriti-os requested a review from krishnamd-jkp March 23, 2026 04:38
Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
@cpriti-os cpriti-os merged commit 2008108 into main Mar 30, 2026
6 checks passed
@cpriti-os cpriti-os deleted the fix-duplicate-x-goog-request-params-4611007834348080142 branch March 30, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants