fix(transport): use ds.GetUniverseDomain() instead of raw ds.UniverseDomain field#3660
Open
yaroshevichg wants to merge 4 commits into
Open
fix(transport): use ds.GetUniverseDomain() instead of raw ds.UniverseDomain field#3660yaroshevichg wants to merge 4 commits into
yaroshevichg wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
GOOGLE_CLOUD_UNIVERSE_DOMAINenvironment variable settings are ignored when dialing gRPC or HTTP transports unlessoption.WithUniverseDomainis explicitly passed in code.Root Cause
DialSettings.GetUniverseDomain()resolves the effective universe domain by checkingds.UniverseDomain, falling back toGOOGLE_CLOUD_UNIVERSE_DOMAIN, and defaulting to"googleapis.com".However,
transport/grpc/dial.goandtransport/http/dial.gopopulateUniverseDomainusing the raw struct fieldds.UniverseDomain. When a client relies onGOOGLE_CLOUD_UNIVERSE_DOMAINfrom the environment without explicitly callingoption.WithUniverseDomain(...),ds.UniverseDomainis empty (""), causing the transport layer to ignore the environment variable.Solution
Use
ds.GetUniverseDomain()when passingUniverseDomainintransport/grpc/dial.goandtransport/http/dial.go.