Added Asynchronous Features To Close Issue #1637 #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the authentication to integrate asynchronous functionality - Modified the where HttpRequest is called to AsyncHttpRequest class Co-authored-by: Kyongsu Kang Co-authored-by: Lizzy Zhou
Co-Author-By: Kyongsu Kang Co-Author-By: Lizzy Zhou
Co-Authored by: Kyongsu Kang Co-Authored by: Lizzy Zhou
Prateikx
reviewed
Apr 9, 2025
Comment on lines
+1361
to
+1364
| if resp.status == 200 and "location" in resp.headers: #Potential Tech Issue problem | ||
| self.resumable_uri = resp.headers["location"] #Potential Tech Issue problem | ||
| else: | ||
| raise ResumableUploadError(resp, content) |
There was a problem hiding this comment.
✨ AI Suggestion: Directly accessing resp.headers["location"] can lead to a KeyError if the header is unexpectedly missing, even if the status code is 200. Use the .get() method for safer access and raise a more specific error if the essential header is absent.
Suggested change
| if resp.status == 200 and "location" in resp.headers: #Potential Tech Issue problem | |
| self.resumable_uri = resp.headers["location"] #Potential Tech Issue problem | |
| else: | |
| raise ResumableUploadError(resp, content) | |
| location = resp.headers.get("location") | |
| if resp.status == 200 and location: | |
| self.resumable_uri = location | |
| else: | |
| # Raise error if status is 200 but location is missing, or if status is not 200 | |
| raise ResumableUploadError( | |
| resp, content, message="Missing 'location' header in resumable URI response." | |
| ) |
Prateikx
reviewed
Apr 9, 2025
Comment on lines
+1464
to
+1467
| # If resp doesn't contain range header, resumable progress is 0 | ||
| self.resumable_progress = 0 | ||
| if "location" in resp: | ||
| self.resumable_uri = resp.headers["location"] #Potential Tech Issue problem |
There was a problem hiding this comment.
✨ AI Suggestion: Directly accessing resp.headers["location"] after a 308 response can lead to a KeyError if the header is missing. Use .get() for safer access to prevent potential runtime errors.
Suggested change
| # If resp doesn't contain range header, resumable progress is 0 | |
| self.resumable_progress = 0 | |
| if "location" in resp: | |
| self.resumable_uri = resp.headers["location"] #Potential Tech Issue problem | |
| except KeyError: | |
| # If resp doesn't contain range header, resumable progress is 0 | |
| self.resumable_progress = 0 | |
| # Use .get() for safer access to the location header | |
| location = resp.headers.get("location") | |
| if location: | |
| self.resumable_uri = location |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added asynchronous features for HTTP requests, authentication, as well as completed some of the checklist below:
Fixes #<1637> 🦕