chore(bazel): get bazel 8 working #15042
Conversation
bazel/workspace0.bzl
Outdated
| # protobuf message. No changes to `patches` should ever be | ||
| # committed to the main branch. | ||
| patch_tool = "patch", | ||
| patch_args = ["-p1"], | ||
| patches = [], | ||
| patch_args = ["-p1", "-l", "-n"], | ||
| patches = ["//bazel:googleapis.workspace.patch"], |
There was a problem hiding this comment.
"No changes to patches should ever be committed to the main branch."
There was a problem hiding this comment.
Agreed. This is just a draft to test the changes before I attempt to upstream them to the googleapis repo.
There was a problem hiding this comment.
I see. Good tactic then. Sorry for jumping the gun.
There was a problem hiding this comment.
Reviewable status: 0 of 291 files reviewed, 1 unresolved discussion (waiting on @devbww)
bazel/workspace0.bzl
Outdated
| # protobuf message. No changes to `patches` should ever be | ||
| # committed to the main branch. | ||
| patch_tool = "patch", | ||
| patch_args = ["-p1"], | ||
| patches = [], | ||
| patch_args = ["-p1", "-l", "-n"], | ||
| patches = ["//bazel:googleapis.workspace.patch"], |
There was a problem hiding this comment.
Agreed. This is just a draft to test the changes before I attempt to upstream them to the googleapis repo.
There was a problem hiding this comment.
Reviewed 1 of 291 files at r1.
Reviewable status: 1 of 291 files reviewed, 1 unresolved discussion (waiting on @scotthart)
bazel/workspace0.bzl
Outdated
| # protobuf message. No changes to `patches` should ever be | ||
| # committed to the main branch. | ||
| patch_tool = "patch", | ||
| patch_args = ["-p1"], | ||
| patches = [], | ||
| patch_args = ["-p1", "-l", "-n"], | ||
| patches = ["//bazel:googleapis.workspace.patch"], |
There was a problem hiding this comment.
I see. Good tactic then. Sorry for jumping the gun.
This change is