chore(storage): remove settable boundary string#212
Merged
brianquinlan merged 5 commits intogoogleapis:mainfrom Mar 23, 2026
Merged
chore(storage): remove settable boundary string#212brianquinlan merged 5 commits intogoogleapis:mainfrom
brianquinlan merged 5 commits intogoogleapis:mainfrom
Conversation
The ability to set a fixed boundary string was previously required because the HTTP recording/replying system required deterministic payloads.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the ability to set a fixed boundary string for multipart requests, a feature previously used for testing to ensure deterministic payloads. The changes involve deleting the fixedBoundaryString global variable and its related logic in pkgs/google_cloud_storage/lib/src/file_upload.dart, along with removing its usage across multiple test files. This refactoring successfully eliminates mutable global state that was specific to testing, improving code isolation and maintainability.
natebosch
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to set a fixed boundary string was previously required because the HTTP recording/replying system required deterministic payloads.