Skip to content

Ignore vscode config#217

Open
sigurdm wants to merge 4 commits intogoogleapis:mainfrom
sigurdm:do_something
Open

Ignore vscode config#217
sigurdm wants to merge 4 commits intogoogleapis:mainfrom
sigurdm:do_something

Conversation

@sigurdm
Copy link
Copy Markdown

@sigurdm sigurdm commented Mar 26, 2026

No description provided.

@brianquinlan
Copy link
Copy Markdown
Contributor

/gcbrun

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to include .vscode directories. A suggestion was made to improve the .vscode ignore rule by removing the leading slash, making it more robust to ignore .vscode directories regardless of their location within the repository. There was also a minor change related to the end-of-file newline for *.tfvars.json.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a BIG fan of telling folks to put this in ~/.gitconfig!!!

so this is a polity 👎 – but not a huge deal 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants