Skip to content

chore(spanner): add gorm data type names for PG types#13584

Merged
rahul2393 merged 1 commit into
mainfrom
add-gorm-data-type-for-pg-types
Jan 12, 2026
Merged

chore(spanner): add gorm data type names for PG types#13584
rahul2393 merged 1 commit into
mainfrom
add-gorm-data-type-for-pg-types

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Add gorm data type names for PostgreSQL-specific types. This prevents gorm from interpreting these structs as models, and automatically creates columns with the correct data type when used as a field in a model.

Needed for googleapis/go-gorm-spanner#199

Add gorm data type names for PostgreSQL-specific types. This prevents
gorm from interpreting these structs as models, and automatically
creates columns with the correct data type when used as a field in a
model.

Needed for googleapis/go-gorm-spanner#199
@olavloite
olavloite requested review from a team January 12, 2026 15:53
@olavloite
olavloite requested a review from a team as a code owner January 12, 2026 15:53
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Jan 12, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the compatibility between GORM and Spanner's PostgreSQL-specific types by implementing the GormDataType() interface for PGNumeric and PGJsonB. This crucial change prevents GORM from misinterpreting these custom types as models, ensuring that database columns are automatically created with the correct PostgreSQL data types when used within a GORM model. This is a foundational step required for a related GORM Spanner integration effort.

Highlights

  • GORM Data Type Integration: Added the GormDataType() method to the PGNumeric type, which returns the string "numeric". This helps GORM correctly identify the database type for fields using PGNumeric.
  • GORM Data Type Integration: Added the GormDataType() method to the PGJsonB type, which returns the string "jsonb". This ensures GORM correctly maps PGJsonB fields to the appropriate PostgreSQL JSONB type.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds GORM data type support for PostgreSQL-specific types PGNumeric and PGJsonB by implementing the GormDataType method for them. The implementation is straightforward. My main feedback is to use pointer receivers for these new methods for consistency with other methods on these types, which is a common Go idiom.

Comment thread spanner/value.go
Comment thread spanner/value.go
@rahul2393
rahul2393 merged commit d23326b into main Jan 12, 2026
10 checks passed
@rahul2393
rahul2393 deleted the add-gorm-data-type-for-pg-types branch January 12, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants