chore(spanner): add gorm data type names for PG types#13584
Conversation
Add gorm data type names for PostgreSQL-specific types. This prevents gorm from interpreting these structs as models, and automatically creates columns with the correct data type when used as a field in a model. Needed for googleapis/go-gorm-spanner#199
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the compatibility between GORM and Spanner's PostgreSQL-specific types by implementing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds GORM data type support for PostgreSQL-specific types PGNumeric and PGJsonB by implementing the GormDataType method for them. The implementation is straightforward. My main feedback is to use pointer receivers for these new methods for consistency with other methods on these types, which is a common Go idiom.
Add gorm data type names for PostgreSQL-specific types. This prevents gorm from interpreting these structs as models, and automatically creates columns with the correct data type when used as a field in a model.
Needed for googleapis/go-gorm-spanner#199