fix(snippets): require ces module in internal/generated/snippets/go.mod#14018
Open
Sebastianhayashi wants to merge 2 commits intogoogleapis:mainfrom
Open
fix(snippets): require ces module in internal/generated/snippets/go.mod#14018Sebastianhayashi wants to merge 2 commits intogoogleapis:mainfrom
Sebastianhayashi wants to merge 2 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a require directive for cloud.google.com/go/ces to internal/generated/snippets/go.mod. This resolves a build error caused by having a replace directive for this module without a corresponding require entry. The change is a single-line addition and appears correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14005.
Root cause
internal/generated/snippets/go.modalready had:replace cloud.google.com/go/ces => ../../../cesbut no matching
requireentry. As a result, CES snippet packages fail to resolve with:module cloud.google.com/go/ces provides package ... and is replaced but not required.Fix
Add a single line in
internal/generated/snippets/go.mod:cloud.google.com/go/ces v0.1.0No other files or dependency versions are changed.
Verification
Target command used in evidence:
cd internal/generated/snippets && go test ./ces/...Observed in evidence logs:
[no test files], build succeeds)Local note: this environment does not have
goinstalled (go: command not found), so I could not re-run Go tests in this shell after cherry-picking the same one-line fix.