Skip to content

feat(bigtable): enable bigtable conn pool by default#14319

Open
sushanb wants to merge 1 commit intogoogleapis:mainfrom
sushanb:enable_conn
Open

feat(bigtable): enable bigtable conn pool by default#14319
sushanb wants to merge 1 commit intogoogleapis:mainfrom
sushanb:enable_conn

Conversation

@sushanb
Copy link
Copy Markdown
Contributor

@sushanb sushanb commented Apr 1, 2026

Can be disabled via CBT_BIGTABLE_CONN_POOL=false.

@sushanb sushanb requested a review from nimf April 1, 2026 01:36
@sushanb sushanb requested review from a team as code owners April 1, 2026 01:36
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the EnableBigtableConnectionPool function to enable the connection pool by default if the environment variable is unset or invalid. The feedback recommends clarifying the code comments to explicitly state the fallback behavior when environment variable parsing fails.

Comment on lines +202 to +203
// just fail and use bigtable conn pool
return true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment 'just fail' is ambiguous. When implementing logic that parses strings, include clear error handling for parsing failures. It is clearer to state that the code is falling back to the default behavior when parsing fails.

Suggested change
// just fail and use bigtable conn pool
return true
// If the environment variable value is invalid, default to enabling the pool.
return true
References
  1. When implementing helper functions that parse strings, always use the provided string parameter and include error handling for parsing failures. For test helpers, panic can be used for unrecoverable parsing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant