feat(firestore): array constants and AggregateFunction serialization#14321
Open
bhshkh wants to merge 2 commits intogoogleapis:mainfrom
Open
feat(firestore): array constants and AggregateFunction serialization#14321bhshkh wants to merge 2 commits intogoogleapis:mainfrom
bhshkh wants to merge 2 commits intogoogleapis:mainfrom
Conversation
…ialization in Firestore pipeline
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for slices and arrays in the ConstantOf function and implements handling for AggregateFunction types within toProtoValue. The review feedback identifies a potential panic in ConstantOf when processing nil values due to unsafe use of reflect.TypeOf and suggests optimizing redundant reflection calls in toProtoValue for better performance and readability.
hongalex
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expr := firestore.ConstantOf([]string{"category1", "category2"})The above query currently, gets translated to below rpc request
{ "name": "aggregate", "args": [ { "mapValue": { "fields": { "averageRating": { "mapValue": {} } } } }, { "mapValue": {} } ] }and receives error "rpc error: code = InvalidArgument desc = Literals are only allowed in a scalar expression."
After fix:
{ "name": "aggregate", "args": [ { "mapValue": { "fields": { "averageRating": { "functionValue": { "name": "average", "args": [ { "fieldReferenceValue": "rating" } ] } } } } }, { "mapValue": {} } ] }