feat(storage): implement Object Contexts with advanced filtering and validation#7548
Open
thiyaguk09 wants to merge 10 commits intogoogleapis:mainfrom
Open
feat(storage): implement Object Contexts with advanced filtering and validation#7548thiyaguk09 wants to merge 10 commits intogoogleapis:mainfrom
thiyaguk09 wants to merge 10 commits intogoogleapis:mainfrom
Conversation
Updated internal request mapping in `file.ts` and `bucket.ts` to include `contexts` in JSON payloads and `filter` in query strings. Fixed baseline unit tests to accommodate the updated destination metadata structure.
- Add support for Object Contexts metadata in `File` and `Bucket` operations. - Update `FileMetadata`, `CopyOptions`, and `CombineOptions` types to allow null values for context key deletion (PATCH semantics). - Refactor `validateContexts` to accept a `contexts` object directly for better consistency and simpler call patterns in `save`, `copy`, and `combine`. - Implement server-side list filtering support via the `filter` query parameter in `getFiles`, supporting NOT logic and existence wildcards. - Ensure metadata inheritance and explicit overrides work correctly during `File.copy` and `Bucket.combine`. - Add comprehensive unit and system tests covering CRUD, server-side operations, and complex filtering scenarios.
product-auto-label
bot
added
the
api: storage
quirogas
added
the
priority: p2
Dhriti07
reviewed
Apr 9, 2026
| const options = | ||
| typeof optionsOrCallback === 'object' ? optionsOrCallback : {}; | ||
|
|
||
| try { |
There was a problem hiding this comment.
Can we have a helper for this logic since it seems to be repeated in many places.
Contributor
Author
There was a problem hiding this comment.
Sure, I will look into it.
Dhriti07
requested changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileandBucketoperations.FileMetadata,CopyOptions, andCombineOptionstypes to allownull values for context key deletion (PATCH semantics).
validateContextsto accept acontextsobject directly forbetter consistency and simpler call patterns in
save,copy, andcombine.filterquery parameterin
getFiles, supporting NOT logic and existence wildcards.File.copyandBucket.combine.operations, and complex filtering scenarios.