Skip to content

fix: upgrade the generator to protobuf 31 and bazel 7.7.1, and update templates to fix system test#7943

Merged
sofisl merged 9 commits intomainfrom
fixSampleTestGeneration
Apr 3, 2026
Merged

fix: upgrade the generator to protobuf 31 and bazel 7.7.1, and update templates to fix system test#7943
sofisl merged 9 commits intomainfrom
fixSampleTestGeneration

Conversation

@sofisl
Copy link
Copy Markdown
Contributor

@sofisl sofisl commented Apr 1, 2026

There were ongoing issues with running the generator, with an old version of protobuf and the c++ errors:

Also! turns out we weren't running tests! In order to run (and pass) tests, I had to:

  • fixed indentation to run tests
  • got rid of the bazel compiler flags in-flight
  • had to make sure eslint points to the root file so that the generator eslint configurations don't point all the way up to the top-level config. FWIW I don't think we should make this is a single file at the root level of the library but if we did, we'd need to remove the "root" I added to the template
  • got rid of the continuous branch for this test since it's a gh action that runs when a pr is opened, so continuous doesn't make sense
  • fixed two templates issues which is what we're seeing today that's blocking our tests: 1) an issue with sinon timers that needs sinon to be pinned, 2) the template issue in which evaluates a cjs file as ts.

@sofisl sofisl requested a review from a team as a code owner April 1, 2026 23:11
@quirogas quirogas self-requested a review April 1, 2026 23:14
@sofisl sofisl changed the title chore: upgrade the generator to protobuf 31 and bazel 7.7.1 fix: upgrade the generator to protobuf 31 and bazel 7.7.1, and update templates to fix system test Apr 3, 2026
@sofisl sofisl merged commit 31fa06f into main Apr 3, 2026
37 checks passed
@sofisl sofisl deleted the fixSampleTestGeneration branch April 3, 2026 16:33
@sofisl sofisl added the release-please:force-run To run release-please label Apr 3, 2026
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants