Skip to content

Fix: resolve intermittent system-test timeouts in common.ts#7945

Open
thiyaguk09 wants to merge 1 commit intogoogleapis:mainfrom
thiyaguk09:fix/system-test-flake-common
Open

Fix: resolve intermittent system-test timeouts in common.ts#7945
thiyaguk09 wants to merge 1 commit intogoogleapis:mainfrom
thiyaguk09:fix/system-test-flake-common

Conversation

@thiyaguk09
Copy link
Copy Markdown
Contributor

  • Implement dynamic port allocation (port 0) for mock servers to avoid EADDRINUSE collisions in CI.
  • Increase timeout to 90s for retry logic to accommodate environmental latency.
  • Ensure mock servers are explicitly closed in both success and failure blocks.
  • Fix async race condition in 'non-responsive hosts' test by moving done() into the callback.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #7343

- Implement dynamic port allocation (port 0) for mock servers to avoid
EADDRINUSE collisions in CI.
- Increase timeout to 90s for retry logic to accommodate environmental
latency.
- Ensure mock servers are explicitly closed in both success and failure
blocks.
- Fix async race condition in 'non-responsive hosts' test by moving
done() into the callback.
@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 2, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thiyaguk09 thiyaguk09 marked this pull request as ready for review April 2, 2026 13:15
@thiyaguk09 thiyaguk09 requested a review from a team as a code owner April 2, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Common Service: should retry a request failed

1 participant