Skip to content

Commit 617a798

Browse files
committed
fix lint and errors
1 parent b2d63ec commit 617a798

3 files changed

Lines changed: 18 additions & 11 deletions

File tree

packages/google-cloud-storage/tests/unit/asyncio/test_async_appendable_object_writer.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,9 @@ async def test_state_lookup(self, mock_appendable_writer):
195195
writer._is_stream_open = True
196196
writer.write_obj_stream = mock_appendable_writer["mock_stream"]
197197

198-
mock_appendable_writer["mock_stream"].recv.return_value = (
199-
storage_type.BidiWriteObjectResponse(persisted_size=100)
200-
)
198+
mock_appendable_writer[
199+
"mock_stream"
200+
].recv.return_value = storage_type.BidiWriteObjectResponse(persisted_size=100)
201201

202202
size = await writer.state_lookup()
203203

@@ -408,9 +408,9 @@ async def test_flush_resets_counters(self, mock_appendable_writer):
408408
writer.write_obj_stream = mock_appendable_writer["mock_stream"]
409409
writer.bytes_appended_since_last_flush = 100
410410

411-
mock_appendable_writer["mock_stream"].recv.return_value = (
412-
storage_type.BidiWriteObjectResponse(persisted_size=200)
413-
)
411+
mock_appendable_writer[
412+
"mock_stream"
413+
].recv.return_value = storage_type.BidiWriteObjectResponse(persisted_size=200)
414414

415415
await writer.flush()
416416

@@ -451,9 +451,9 @@ async def test_finalize_lifecycle(self, mock_appendable_writer):
451451
writer.write_obj_stream = mock_appendable_writer["mock_stream"]
452452

453453
resource = storage_type.Object(size=999)
454-
mock_appendable_writer["mock_stream"].recv.return_value = (
455-
storage_type.BidiWriteObjectResponse(resource=resource)
456-
)
454+
mock_appendable_writer[
455+
"mock_stream"
456+
].recv.return_value = storage_type.BidiWriteObjectResponse(resource=resource)
457457

458458
res = await writer.finalize()
459459

packages/google-cloud-storage/tests/unit/asyncio/test_async_write_object_stream.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
from google.cloud import _storage_v2
2222
from google.cloud.storage import Blob
23+
from google.cloud.storage import Bucket
2324
from google.cloud.storage.asyncio.async_write_object_stream import (
2425
_AsyncWriteObjectStream,
2526
)
@@ -161,9 +162,15 @@ async def test_open_new_object_with_blob_sync_attrs(
161162
mock_rpc.open = AsyncMock()
162163
mock_rpc.recv = AsyncMock(return_value=MagicMock(resource=None))
163164

165+
mock_bucket = mock.Mock(spec=Bucket)
166+
mock_bucket.name = BUCKET
167+
164168
mock_blob = mock.Mock(spec=Blob)
169+
mock_blob.name = OBJECT
170+
mock_blob.bucket = mock_bucket
165171
mock_blob.content_type = "text/plain"
166172
mock_blob.metadata = {"test-key": "test-value"}
173+
mock_blob.kms_key_name = None
167174

168175
stream = _AsyncWriteObjectStream(mock_client, BUCKET, OBJECT, blob=mock_blob)
169176
await stream.open()

packages/google-cloud-storage/tests/unit/test_fileio.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -922,8 +922,8 @@ def test_write(self, mock_warn):
922922

923923
# The transmit_next_chunk method must actually consume bytes from the
924924
# sliding buffer for the flush() feature to work properly.
925-
upload.transmit_next_chunk.side_effect = (
926-
lambda _: unwrapped_writer._buffer.read(chunk_size)
925+
upload.transmit_next_chunk.side_effect = lambda _: (
926+
unwrapped_writer._buffer.read(chunk_size)
927927
)
928928

929929
# Write under chunk_size. This should be buffered and the upload not

0 commit comments

Comments
 (0)