chore(ndb): Add nox sessions for system tests#16530
chore(ndb): Add nox sessions for system tests#16530vbraun wants to merge 1 commit intogoogleapis:mainfrom
Conversation
This just adds the nox session decorators so you can run the system tests with ``` cd packages/google-cloud-ndb nox -s emulator_system ``` The actual system tests don't pass, though. See also googleapis#15866 (comment)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates packages/google-cloud-ndb/noxfile.py to expose the old_emulator_system and emulator_system functions as Nox sessions across all interpreters. A review comment suggests removing the session decorator from old_emulator_system to avoid developer confusion, as the prefix implies it may be deprecated or not intended for standard use.
| @nox.session(python=ALL_INTERPRETERS) | ||
| def old_emulator_system(session): |
There was a problem hiding this comment.
Exposing a function named old_emulator_system as a nox session can be confusing for developers, as the old_ prefix suggests it might be deprecated. If this function is not intended for regular use, it would be better not to expose it as a top-level session to avoid confusion. Please consider removing the @nox.session decorator.
| @nox.session(python=ALL_INTERPRETERS) | |
| def old_emulator_system(session): | |
| def old_emulator_system(session): |
daniel-sanche
changed the title
2 participants
This just adds the nox session decorators so you can run the system tests with
The actual system tests don't pass, though.
See also #15866 (comment)